Skip to content

Bundle config reference #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 20, 2016
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 18, 2016

This will fix #107 and #114

TODO

  • Add images

@Nyholm
Copy link
Member Author

Nyholm commented Jul 18, 2016

This will also fix #113

@sagikazarmark
Copy link
Member

👍

client: 'httplug.clients.my_guzzle5'
async_client: 'auto'

The debug info for normal HTTP clients are enabled by default but not for async clients. You can turn all debug info off for auto discovered clients by setting the value to ``false``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try to make this more readable:

For normal clients, the auto discovery debug info is enabled by default. For async clients, debug is not enabled by default to avoid errors when using the bundle with a client that can not do async. To get debug information for async clients, set discovery.async_client to 'auto' or an explicit client.

You can turn off all interaction of the bundle with auto discovery by setting the value of discovery.client to false.

@dbu
Copy link
Contributor

dbu commented Jul 19, 2016

👍

@Nyholm
Copy link
Member Author

Nyholm commented Jul 19, 2016

Thank you for the reviews. I've updated my PR

toolbar:
captured_body_length: 1000 # Capture the first 1000 chars of the HTTP body

The toolbar is automatically turned of when ``kernel.debug = false``. You can also disable the toolbar by configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/of/off/

@Nyholm Nyholm merged commit 3e88685 into php-http:master Jul 20, 2016
@Nyholm Nyholm deleted the bundle-config-reference branch July 20, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttplugBundle] configuration for client wrappers
3 participants